Hi, On Thu, Sep 1, 2011 at 2:30 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On Mon, 2011-08-29 at 11:44 +0530, mythripk@xxxxxx wrote: >> From: Mythri P K <mythripk@xxxxxx> >> >> Some of the header file definitions of HDMI IP are needed by audio driver thus >> moving the common defintion to more generic Include/video. >> >> Signed-off-by: Mythri P K <mythripk@xxxxxx> >> --- >> drivers/video/omap2/dss/dss.h | 10 ----- >> drivers/video/omap2/dss/hdmi.c | 1 + >> drivers/video/omap2/dss/hdmi.h | 53 ------------------------ >> include/video/omaphdmi.h | 86 ++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 87 insertions(+), 63 deletions(-) >> create mode 100644 include/video/omaphdmi.h > > As the functions will be renamed to hdmi_ti_4xxx_*, perhaps the header > file is a bit misnamed. > > Also, please first do the changes/renamings/etc, and only then move the > finished header file to include/video/ to prevent unnecessary changes in > include/video. > The Include/video hdmi header file is a generic file that can be used across 4 ,5 and Netra. Actually even the hdmi_ti_5xxx_ definitions would come in this header so what do you think it can be named as ? , If you have any better name for hdmi_ti_4xxx_ip as well please suggest would be happy to take it , as it doesn't sound that intuitive to me as well. > Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
