On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: > Hi > > Some comments. > > On Wed, 31 Aug 2011, Keerthy wrote: > [ ... ] > > > +} > > + > > +/* Sysfs hook functions */ > > These should be conditionally compiled out if sysfs isn't compiled in. > The whole point of the hwmon subsystem is to expose hardware monitoring information to userland using sysfs. hwmon without sysfs doesn't make sense. So, if anything, it might make sense to disable the entire hwmon tree if sysfs is disabled. But please no conditionals in the code. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
