On Thu, Aug 25, 2011 at 11:16:25AM -0700, Kevin Hilman wrote: > Arnd Bergmann <arnd@xxxxxxxx> writes: > > On Thursday 25 August 2011, Russell King - ARM Linux wrote: > >> On Thu, Aug 25, 2011 at 02:16:14AM +0300, Felipe Balbi wrote: > >> > on top of all that, for IPs which are used on many SoCs (such as MUSB) > >> > it's quite silly to force all users to provide resources in a certain > >> > order. It sounds to me that this will be prone to error in many ways > >> > until everything is synced up and on the correct order. > >> > > >> > Ditching _byname is a very bad idea. > >> > >> I continue to disagree. The current _byname is an abonimation and hack > >> to try to "fix" this problem. > >> > >> _byname should have been implemented differently - rather than overriding > >> the resources name field (which is normally specified to be the device > >> or driver name), a new field should have been introduced in struct resource > >> to carry the resource sub-name (which is really what it is.) > >> > >> That would have avoided making /proc/iomem completely illegible with > >> multiple devices using this feature. > > > > I agree 100%. > > Please clarify. > > What I hear Russell saying is a problem with the *implementation* of the > _byname API. > > What I hear you sating is that since DT doesn't support this, we need to > remove it's usage completely from platform_devices also. > > These are two very different approaches. > > Fixing the implementation as Russell suggested seems relatively easy, > and conceptually similar to adding it to the DT. Removing _byname all > together seems like significant work just to avoid adding a feature to > the DT core. Seriously, how many times do I have to say it? Using _byname in drivers DOES NOT require adding names to the DT. All it needs is some glue logic to attach names as the device tree is read. This is properly thought of as part of the code which translates the device tree into struct platform_device, not as part of drivers proper. FURTHERMORE, even if there were names in the DT, you'd *still* need this glue logic, so that drivers converted to _byname could still use old device trees. Insisting that the names come from the DT is to mistakenly think of the DT as an extension of the kernel's internal interfaces, instead of as the external and OS neutral data structure it actually is. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
