Hello Tomi, On Mon, 22 Aug 2011, Tomi Valkeinen wrote: > On Sat, 2011-08-20 at 00:26 -0600, Paul Walmsley wrote: > > On Fri, 19 Aug 2011, Paul Walmsley wrote: > > > > > This one doesn't build when !CONFIG_OMAP2_DSS - the following is the > > > updated patch. > > > > Looks like my previous update missed a warning. This also moves the > > omap_dss_reset() prototype from arch/arm/mach-omap2/common-board-devices.h > > to arch/arm/plat-omap/include/plat/common.h. > > Related to this, there's also omap_display_init() function in display.c, > called by the board files, which I would like to move elsewhere from > include/video/omapdss.h. > > I was thinking of moving it to > arch/arm/mach-omap2/common-board-devices.h but should I move it to > arch/arm/plat-omap/include/plat/common.h so that it's in the same place > with omap_dss_reset() (also from display.c)? In the long run, it seems good to get rid of arch/arm/plat-omap/include/plat/common.h. What I'd suggest is to move all of the OMAP2+-specific integration structures and macros into arch/arm/mach-omap2/omapdss.h or something similar. I would have done this in the 3.1-rc patch, but the change seemed too intrusive for the -rc series. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
