Re: [PATCHv2 0/5] OMAP DSS HWMOD fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Monday 08 August 2011 02:45 PM, Valkeinen, Tomi wrote:
Second try with the DSS HWMODs

This set fixes the DSS clocks in HWMOD data, and implements a new reset
mechanism for dss_core.

The new dss_reset function doesn't actually do a reset, it just enables all DSS
clocks and waits for the reset to complete. This should be better approach than
actually doing a reset, because:

OMAP4 - dss_core HW doesn't contain a SW reset bit so doing a reset is
impossible. But after power-on we need to enable all DSS clocks and wait for
the power-on reset to complete.

OMAP2/3 - dss_core does have a SW reset bit, but resetting dss_core also resets
all the other DSS modules. This means that the other modules could be left
uninitialized, as the hwmod code handles all modules independently, and in this
case initializes only dss_core's registers. Thus dss_core's reset shouldn't be
used, and we should only verify that the power-on reset has completed.

If the bootloader enables DSS, we need to do a reset so that DSS2 driver can start with DSS HW in a clean state. With this patch set, how do we take care of such a scenario?

Archit


Tested on OMAP4 and OMAP3.

The first two HWMOD patches (for OMAP2/3) are not changed since v1.

  Tomi

Tomi Valkeinen (5):
   OMAP2xxx: HWMOD: fix DSS opt clocks
   OMAP3: HWMOD: fix DSS opt clocks
   OMAP4: HWMOD: fix DSS opt clocks
   OMAP2/3: HWMOD: Add SYSS_HAS_RESET_STATUS for dss
   OMAP: HWMOD: Unify DSS resets for all OMAPs

  arch/arm/mach-omap2/common-board-devices.h         |    4 ++
  arch/arm/mach-omap2/display.c                      |   35 ++++++++++++++++++++
  arch/arm/mach-omap2/omap_hwmod_2420_data.c         |   15 +++++++-
  arch/arm/mach-omap2/omap_hwmod_2430_data.c         |   15 +++++++-
  .../mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c |    5 ++-
  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c         |   35 +++++++++++++++++--
  arch/arm/mach-omap2/omap_hwmod_44xx_data.c         |   18 +++-------
  7 files changed, 106 insertions(+), 21 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux