Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 22, 2011 at 09:59:46AM +0530, J, KEERTHY wrote:
> >> +static const struct dev_pm_ops omap_temp_sensor_dev_pm_ops = {
> >> +     .suspend = omap_temp_sensor_suspend,
> >> +     .resume = omap_temp_sensor_resume,
> >> +     .runtime_suspend = omap_temp_sensor_runtime_suspend,
> >> +     .runtime_resume = omap_temp_sensor_runtime_resume,
> >> +};
> >
> > this is not enough... you need to populate the other fields. You might
> > want to use something like:
> >
> > static const struct dev_pm_ops omap_temp_sensor_dev_pm_ops = {
> >        SET_SYSTEM_SLEEP_PM_OPS(omap_temp_sensor_suspend,
> >                omap_temp_sensor_resume)
> >        SET_RUNTIME_PM_OPS(omap_temp_sensor_runtime_suspend,
> >                omap_temp_sensor_runtime_resume, omap_temp_sensor_idle)
> > };
> 
> omap_temp_sensor_idle is undefined for temperature sensor as of now. So i will
> populate these fields once the idle function is defined.

make a nop idle function. Those other fields _must_ be populated. Use
something like:

static int omap_temp_sensor_idle(struct device *dev)
{
	/* nothing to do here */
	return 0;
}

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux