Hello, The rfc patch series for the on die temperature sensor driver. I need feedback on the overall structure of the driver. The rfc patch set has the device file, omap4 on die temperature sensor hwmon driver. hwmod, clk support. The patch set compiles on top of LO tree Master branch. This patch series is tested for boot-up on OMAP4460. The temperature reading and the interrupts generation on crossing the temperature thresholds also tested. V2: (1) Fixed comments on return values in the driver. (2) Moved the TEMPSOFF setting code to the activate/deactivate hooks. (3) Used idr to pass for the device id. Benoit Cousson (1): OMAP4: Hwmod: OMAP temperature sensor Keerthy (5): OMAP4: Clock: Associate clocks for OMAP temperature sensor OMAP4: Adding the temperature sensor register set bit fields OMAP4460: Temperature sensor data OMAP4: Temperature sensor device support hwmon: OMAP4: On die temperature sensor driver Documentation/hwmon/omap_temp_sensor | 27 + arch/arm/mach-omap2/Makefile | 3 +- arch/arm/mach-omap2/clock44xx_data.c | 2 +- .../include/mach/ctrl_module_core_44xx.h | 70 ++- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 61 ++ arch/arm/mach-omap2/temp_sensor4460_data.c | 63 ++ arch/arm/mach-omap2/temp_sensor_device.c | 178 ++++ arch/arm/plat-omap/Kconfig | 12 + .../plat-omap/include/plat/temperature_sensor.h | 89 ++ drivers/hwmon/Kconfig | 11 + drivers/hwmon/Makefile | 1 + drivers/hwmon/omap_temp_sensor.c | 918 ++++++++++++++++++++ 12 files changed, 1420 insertions(+), 15 deletions(-) create mode 100644 Documentation/hwmon/omap_temp_sensor create mode 100644 arch/arm/mach-omap2/temp_sensor4460_data.c create mode 100644 arch/arm/mach-omap2/temp_sensor_device.c create mode 100644 arch/arm/plat-omap/include/plat/temperature_sensor.h create mode 100644 drivers/hwmon/omap_temp_sensor.c -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
