Nishanth Menon <nm@xxxxxx> writes:
> Suspend and Resume paths are safe enough to do it in
What is 'it' ?
> the standard LDM suspend/resume handlers where one can
> sleep. Add suspend/resume handlers for SmartReflex.
Minor comments on the code below, but this changelog doesn't read well,
or at least I can't make any sense of it.
[...]
> @@ -684,6 +685,12 @@ void omap_sr_enable(struct voltagedomain *voltdm)
> if (!sr->autocomp_active)
> return;
>
> + if (sr->is_suspended) {
> + dev_dbg(&sr->pdev->dev, "%s: in suspended state\n", __func__);
> + return;
> + }
> +
> +
extra blank line
> if (!sr_class || !(sr_class->enable) || !(sr_class->configure)) {
> dev_warn(&sr->pdev->dev, "%s: smartreflex class driver not"
> "registered\n", __func__);
[...]
> static struct platform_driver smartreflex_driver = {
> .remove = omap_sr_remove,
> + .suspend = omap_sr_suspend,
> + .resume = omap_sr_resume,
You're using the legacy methods here, please use dev_pm_ops.
That means you'll need to create a struct dev_pm_ops and fill in these
mehods there (and note the dev_pm_ops methods don't have a 'state'
argument.
Also, when implementing suspend/resume, you need to make sure the
hibernate callbacks are populated also. They should be populated with
the same callbacks, so the best way to do this is to use
SIMPLE_DEV_PM_OPS() (see <linux/pm.h>). That macro also takes care of
the !CONFIG_PM case as well.
IOW, the result would look someting like this (not even compile tested):
static SIMPLE_DEV_PM_OPS(omap_sr_pm_ops, omap_sr_suspend, omap_sr_resume)
static struct platform_driver smartreflex_driver = {
.remove = omap_sr_remove,
.driver = {
.name = "smartreflex",
.pm = &omap_sr_pm_ops,
},
};
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
