On Fri, Jul 08, 2011 at 06:56:25PM +0300, Tero Kristo wrote: > This commit adds two things to the TWL regulator driver code : Why is this one commit rather than two commits implementing the two changes? > * It creates a twlreg_ext_ctrl structure, which allows code outside > of the TWL regulator driver to implement a regulator > controller. Such a controller is attached using the new > twlreg_attach_external_controller() function of the driver. When > such a controller is attached to a regulator, the ->set_voltage() > and ->get_voltage() calls made on the regulator will be forwarded > to the external controller. This facility will later be used to > integrate the Voltage Controller and SmartReflex features of the > OMAP CPU with this regulator driver. The regulator API has perfectly good support for multiple regulators in the system already, why would this driver know anything about other regulators in the system? If there is something missing why are you implementing it in a driver and not the core? I've not read the actual patch. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
