Re: [RFC 0/4] TWL external controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

On Fri, Jul 08, 2011 at 06:56:24PM +0300, Tero Kristo wrote:
> Following patches add an external controller support for TWL SMPS regulators.
> This is needed because OMAP has voltage processor support which provides
> interface to control a few regulators (VDD1 / VDD2 for OMAP3), and this
> is shared with smartreflex.
> 
> These patches work in a way that twl regulators now provide an external
> controller registration interface, and this is used by the OMAP voltage
> layer during init. set_voltage / get_voltage APIs now check for presence
> of external controller, and if it is there, calls are routed to external
> controller.
> 
> Baseline work for these patches was done by Thomas Petezzoni.
> 
> Any comments welcome, does something like this look like it could be pushed
> to regulator framework?

isn't this all the same as claiming the regulator but never actually
using the regulator APIs ? I mean, you could add the regulator, then on
smartreflex code, regulator_get(), but when it gets to get/set voltage,
you use the omap_*() functions instead of regulator_*().

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux