[...]
> >
> > By adding level and edge detection register offsets and then
> initializing them
> > correctly according to OMAP versions during device registrations we can
> now remove
> > lot of revision checks in these functions.
> >
> > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> > Signed-off-by: Charulatha V <charu@xxxxxx>
>
> Looks good. One very minor nit below...
>
> [...]
>
> > @@ -1247,40 +1240,18 @@ void omap2_gpio_prepare_for_idle(int off_mode)
> > if (!(bank->enabled_non_wakeup_gpios))
> > goto save_gpio_ctx;
> >
> > - if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
> > - bank->saved_datain = __raw_readl(bank->base +
> > - OMAP24XX_GPIO_DATAIN);
> > - l1 = __raw_readl(bank->base +
> > - OMAP24XX_GPIO_FALLINGDETECT);
> > - l2 = __raw_readl(bank->base +
> > - OMAP24XX_GPIO_RISINGDETECT);
> > - }
> > -
> > - if (cpu_is_omap44xx()) {
> > - bank->saved_datain = __raw_readl(bank->base +
> > - OMAP4_GPIO_DATAIN);
> > - l1 = __raw_readl(bank->base +
> > - OMAP4_GPIO_FALLINGDETECT);
> > - l2 = __raw_readl(bank->base +
> > - OMAP4_GPIO_RISINGDETECT);
> > - }
> > + bank->saved_datain = __raw_readl(bank->base +
> > + bank->regs->datain);
> > + l1 = __raw_readl(bank->base + bank->regs->fallingdetect);
> > + l2 = __raw_readl(bank->base + bank->regs->risingdetect);
>
> The l1 = 0, l2 = 0 assignments can now be removed at the beginning of
> this function also. Similarily for the 'l = 0' assignment in the
> runtime_resume function.
Ok.
--
Tarun
>
> Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
