> -----Original Message----- > From: Hilman, Kevin > Sent: Thursday, July 07, 2011 2:25 AM > To: DebBarma, Tarun Kanti > Cc: linux-omap@xxxxxxxxxxxxxxx; Shilimkar, Santosh; tony@xxxxxxxxxxx > Subject: Re: [PATCH v3 19/20] GPIO: OMAP: optimize suspend and resume > functions > > Tarun Kanti DebBarma <tarun.kanti@xxxxxx> writes: > > > There is no need to operate on all the banks every time the function is > called. > > Just operate on the current bank passed by the framework. > > That's a good change. > > There is also no need to runtime suspend/resume the bank if > bank->suspend_wakeup == 0 during suspend (or bank->saved_wakeup == 0 > during resume.) > > IOW, banks with no wakeups enabled have an unnecessary runtime > resume/suspend in both the system suspend and resume path. Ok, I will incorporate the change. -- Tarun > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
