Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

On 27 June 2011 13:30, Felipe Balbi <balbi@xxxxxx> wrote:

>> >
>> > +static struct regulator_consumer_supply sdp4430_vusb_supply =
>> > +       REGULATOR_SUPPLY("hsusb0", "ehci-omap.0");
>
> this should be an array.
Ok, I can make it an array of _one_ element.
Though I am not sure why is that a good thing, or are we to use another
possible VUSB supply on Panda/SDP boards ?  Please suggest so that
I can add that too.

>> >  static struct regulator_init_data sdp4430_vusb = {
>> >        .constraints = {
>> >                .min_uV                 = 3300000,
>> >                .max_uV                 = 3300000,
>> > -               .apply_uV               = true,
>> >                .valid_modes_mask       = REGULATOR_MODE_NORMAL
>> >                                        | REGULATOR_MODE_STANDBY,
>> >                .valid_ops_mask  =      REGULATOR_CHANGE_MODE
>> >                                        | REGULATOR_CHANGE_STATUS,
>> >        },
>> > +       .num_consumer_supplies  = 1,
>
> ARRAY_SIZE()
Yes, of course if we are to switch to single-element array.

Thanks,
Jassi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux