Re: [PATCH 1/2] OMAP4 :TWL6030: Regulator set the default behavior of LDO's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 22, 2011 at 5:54 AM, Girish S G <girishsg@xxxxxx> wrote:
> TWL6030 below table shows the default state each LDO's can
> be put into.
>
>        +---------------------------------------------------------------+
>        | LDO   |       Usage           |       state                   |
>        +---------------------------------------------------------------+
>        | VANA  | sources internal      | Always ON                     |
>        |       | analog voltage        |                               |
>        +---------------------------------------------------------------+
>        | VAUX1 | eMMC                  | MMC Driver needs to handle    |
>        |       |                       |                               |
>        +---------------------------------------------------------------+
>        | VAUX2 | A/V switch            | Driver needs to handle        |
>        +---------------------------------------------------------------+
>        | VAUX3 | 5MP CAMp              | Driver needs to handle        |
>        +---------------------------------------------------------------+
>        | VCXIO | supplies DPLL's       | Can be put OFF when OMAP hits |
>        |       |                       | OFF mode.                     |
>        +---------------------------------------------------------------+
>        | VDAC  | HDMI, CDC chip        | Always ON                     |
>        +---------------------------------------------------------------+
>        | VMMC  | MMC                   | Driver needs to handle        |
>        +---------------------------------------------------------------+
>        | VPP   | VPP pins of OMAP      | Used while burning fuses in   |
>        |       |                       | OMAP. This can be turned OFF  |
>        |       |                       | by default when kernel comes  |
>        |       |                       | up.                           |
>        +---------------------------------------------------------------+
>        | VRTC  | VBRTC/RTC             | Always ON                     |
>        +---------------------------------------------------------------+
>        | VUSB  | USB OTG pins          | Driver needs to handle        |
>        +---------------------------------------------------------------+
>        | VUSIM | VDDS_SIM, SIM cage    | Driver needs to handle.       |
>        +---------------------------------------------------------------+
>        | CLK32K| 32KHz o/p clk         | WIFI/BT/FM/GPS driver needs   |
>        |       |                       | to handle                     |
>        +---------------------------------------------------------------+
>
>  - VDAC, VANA, VCXIO and VRTC should be kept always ON. As per the table above.
>
> Need REVISIT on below LDO's:
>  - VAUX1 kept ON now. MMC driver needs to take care of enabling/disabling
>   as needed. Issue seen with eMMC bootup with VAUX1 disabled by default.
>
>  - VAUX3 is kept ON now. CAM/syslink should handle this regulator. This
>   is only for 5MP camera on Blaze.
>
>  - CLK32KG is pseudo regulator, on Blaze/panda it supplies GPS/WIFI/BT/FM/GPS
>   Drivers should handle it. Keeping it always ON as of now.

description and code changes are not in sync.
vmmc, vana, vdac, vusb is kept as always_on.
Can you try boot_on if it fits you requirement.

-- 
Thanks and Regards,
Balaji T K

>
> Signed-off-by: Girish S G <girishsg@xxxxxx>
> ---
>  arch/arm/mach-omap2/board-4430sdp.c    |    4 ++++
>  arch/arm/mach-omap2/board-omap4panda.c |    3 +++
>  2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 63de2d3..04b7770 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -440,6 +440,7 @@ static struct regulator_init_data sdp4430_vmmc = {
>                .valid_ops_mask  = REGULATOR_CHANGE_VOLTAGE
>                                        | REGULATOR_CHANGE_MODE
>                                        | REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>        .num_consumer_supplies  = 1,
>        .consumer_supplies      = sdp4430_vmmc_supply,
> @@ -479,6 +480,7 @@ static struct regulator_init_data sdp4430_vana = {
>                                        | REGULATOR_MODE_STANDBY,
>                .valid_ops_mask  = REGULATOR_CHANGE_MODE
>                                        | REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>  };
>
> @@ -501,6 +503,7 @@ static struct regulator_init_data sdp4430_vdac = {
>                                        | REGULATOR_MODE_STANDBY,
>                .valid_ops_mask  = REGULATOR_CHANGE_MODE
>                                        | REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>  };
>
> @@ -519,6 +522,7 @@ static struct regulator_init_data sdp4430_vusb = {
>  static struct regulator_init_data sdp4430_clk32kg = {
>        .constraints = {
>                .valid_ops_mask         = REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>  };
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 0cfe200..3415a5e 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -337,6 +337,7 @@ static struct regulator_init_data omap4_panda_vana = {
>                                        | REGULATOR_MODE_STANDBY,
>                .valid_ops_mask  = REGULATOR_CHANGE_MODE
>                                        | REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>  };
>
> @@ -359,6 +360,7 @@ static struct regulator_init_data omap4_panda_vdac = {
>                                        | REGULATOR_MODE_STANDBY,
>                .valid_ops_mask  = REGULATOR_CHANGE_MODE
>                                        | REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>  };
>
> @@ -377,6 +379,7 @@ static struct regulator_init_data omap4_panda_vusb = {
>  static struct regulator_init_data omap4_panda_clk32kg = {
>        .constraints = {
>                .valid_ops_mask         = REGULATOR_CHANGE_STATUS,
> +               .always_on      = true,
>        },
>  };
>
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux