On Tuesday 07 June 2011 17:45:35 Tony Lindgren wrote: > > +#define TWL_COMMON_PDATA_BCI (1 << 1) > > +#define TWL_COMMON_PDATA_MADC (1 << 2) > > +#define TWL_COMMON_PDATA_CODEC (1 << 3) > > This is looking good, thanks for cleaning up the twl bloat in > board-*.c files :) As I recall the first three patch results ~600 less lines of code under mach- omap2. > Maybe already define TWL_COMMON_PDATA_AUDIO here so you can > drop most of patch 7/12? > > If you need both then you can temporarily have: > > #define TWL_COMMON_PDATA_CODEC TWL_COMMON_PDATA_AUDIO I have not thought about this. But I think we can live with the TWL_COMMON_PDATA_AUDIO all the way. I'll wait for more comments, and I'll do this for the v3. Thanks, Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html