On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh <vimal.newwork@xxxxxxxxx> wrote: > On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote: >> >> -static int omap2_nand_gpmc_retime(void) >> +static int omap2_nand_gpmc_retime(struct omap_nand_platform_data *gpmc_nand_data) >> { >> struct gpmc_timings t; >> int err; >> @@ -83,13 +81,11 @@ static int omap2_nand_gpmc_retime(void) >> return 0; >> } >> >> -int __init gpmc_nand_init(struct omap_nand_platform_data *_nand_data) >> +int __init gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data) >> { >> int err = 0; >> struct device *dev = &gpmc_nand_device.dev; >> >> - gpmc_nand_data = _nand_data; >> - gpmc_nand_data->nand_setup = omap2_nand_gpmc_retime; > > Purpose of doing this was to be able to utilise > 'omap2_nand_gpmc_retime', when DVFS is ready to use it, > for changing timing parameter dynamically when a frequency change is done. Well but it seems currently ...retime() only does single static configuration, I guess when it's updated to do DVFS stuff callback can easily be added back.. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html