Re: [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Todd Poynor <toddpoynor@xxxxxxxxxx> [110526 12:22]:
> !dev case needs iounmap before return.

Adding to fixes thanks.

Tony
 
> Signed-off-by: Todd Poynor <toddpoynor@xxxxxxxxxx>
> ---
>  arch/arm/mach-omap2/omap_phy_internal.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
> index ae97336..bd563cf 100644
> --- a/arch/arm/mach-omap2/omap_phy_internal.c
> +++ b/arch/arm/mach-omap2/omap_phy_internal.c
> @@ -56,8 +56,10 @@ int omap4430_phy_init(struct device *dev)
>  	/* Power down the phy */
>  	__raw_writel(PHY_PD, ctrl_base + CONTROL_DEV_CONF);
>  
> -	if (!dev)
> +	if (!dev) {
> +		iounmap(ctrl_base);
>  		return 0;
> +	}
>  
>  	phyclk = clk_get(dev, "ocp2scp_usb_phy_ick");
>  	if (IS_ERR(phyclk)) {
> -- 
> 1.7.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux