Re: [PATCH] OMAP4: fix return value of omap4_l3_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Rabin Vincent <rabin@xxxxxx> [110507 09:54]:
> Don't PTR_ERR() a non-error pointer:
> 
>  initcall omap4_l3_init+0x0/0xdc returned -544980480 after 0 usecs
>  initcall omap4_l3_init+0x0/0xdc returned with error code -544980480

Adding to fixes thanks.

Tony
 
> Signed-off-by: Rabin Vincent <rabin@xxxxxx>
> ---
>  arch/arm/mach-omap2/devices.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 7b85585..5b8ca68 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -97,7 +97,7 @@ static int __init omap4_l3_init(void)
>  
>  	WARN(IS_ERR(od), "could not build omap_device for %s\n", oh_name);
>  
> -	return PTR_ERR(od);
> +	return IS_ERR(od) ? PTR_ERR(od) : 0;
>  }
>  postcore_initcall(omap4_l3_init);
>  
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux