On Wed, 2011-05-18 at 17:41 +0300, Tomi Valkeinen wrote: > On Wed, 2011-05-18 at 16:24 +0200, Kevin Hilman wrote: > > > Looking closer at the code, a zero return happens only when > > > > 1) no hwmod associated to omap_device > > 2) no power domain associated to hwmod > > 3) power domain has not (yet) lost context > > > > None of these are actually error conditions per-se, and in all cases, it > > indidates that context has not been lost (or we can't tell if context > > has been lost.) > > If the pm code cannot tell whether the context has been lost or not, the > driver must assume it has been lost, do you agree? If so, the driver > must handle zero return value differently, and always restore context. > > > So I think the current code is correct. > > How is it correct if it returns an error even if no error has happened > =)? Either the code or the documentation is wrong. > > How about the wrap-around case? Does the loss count go back to zero? Any conclusion on this? Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
