jean.pihet@xxxxxxxxxxxxxx writes: > From: Jean Pihet <j-pihet@xxxxxx> > > Rework of the OMAP2+ cpuidle code Excellent work! Thanks. Queuing for 2.6.40 (branch: for_2.6.40/pm-cleanup) Kevin > v3: rework after comments on linux-omap ML: > - renamed the C-state driver data variables as 'cx', > - retain C1 as the only always valid state and safe state, > - rework of the C-states definition. > > v2: rework after comments on linux-omap ML: > - remove useless macros, > - replace the C-state common data fill-in helper macro by an inline > function, for better readability, > - update commits description. > > v1: > - optimize the cpuidle C-states data registration and storage, > - change the interaction with the debugfs 'enable_off_mode' knob > and the use of the C-states 'valid' internal field, > - remove dead code, > - improve code readability. > > Tested on Beagleboard B5 with cpuidle in RET and OFF modes. > > Another 151 lines of OMAP code gone ;p > > Notes: > 1) the debugfs 'enable_off_mode' knob will be deprecated by the use > of the devices constraints framework to restrict the power domains > power modes. > 2) the MPU and CORE power domains low power modes are controlled > by cpuidle, based on the allowed overall sleep+wake-up latencies > and the wake-up latency constraints on the MPU. This is incorrect. > The devices constraints framework shall be used instead to control > all power domains. > > ToDo: > - integrate cpuidle with the devices constraints framework, when merged in, > - refine the latency figures and express them in term of available data > from other frameworks (OMAP PM, constaints framework, omap_devices, > new VC/VP voltage and DVFS code ...), > > Rebased on khilman's for_2.6.40/pm-cleanup branch > > > Jean Pihet (4): > OMAP3: clean-up mach specific cpuidle data structures > OMAP3: cpuidle: re-organize the C-states data > OMAP3: cpuidle: code rework for improved readability > OMAP3: cpuidle: change the power domains modes determination logic > > arch/arm/mach-omap2/board-rx51.c | 18 +- > arch/arm/mach-omap2/cpuidle34xx.c | 436 +++++++++++++------------------------ > arch/arm/mach-omap2/pm.h | 17 +- > arch/arm/mach-omap2/pm34xx.c | 12 - > 4 files changed, 166 insertions(+), 317 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
