Jarkko Nikula <jhnikula@xxxxxxxxx> writes: > On Tue, 17 May 2011 19:33:41 +0200 > Kevin Hilman <khilman@xxxxxx> wrote: > >> Hi Sanjeev, >> >> On Tue, 2011-05-17 at 20:32 +0530, Sanjeev Premi wrote: >> > With current level, it shows up on the console >> > despite using 'silent' in bootargs. >> > >> > Signed-off-by: Sanjeev Premi <premi@xxxxxx> >> > --- >> > >> > 1) Couldn't find better text on commit message. >> > Any suggestions? >> > >> > 2) Though pm34xx.x is changed, the change itself >> > is no related to power management. Hence, did >> > annotate "pm:" >> >> Well, it's a change to PM core code, so PM prefix is fine. How about: >> >> OMAP3: PM: boot message is not an error, use pr_info >> >> Also, please Cc linux-arm-kernel, and I will queue this fix for 2.6.40. > ... >> > arch/arm/mach-omap2/pm34xx.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > > Does this bootup info print here bring any benefit for pm developers > and users? > > For me it looks it can be removed as the pm34xx.c is always compiled > and initialized for CONFIG_ARCH_OMAP3 so IMHO only error prints from > pm34xx.c are relevant. Good point. It's probably better to simply remove the printk. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
