Hi Sanjeev,
On Tue, 2011-05-17 at 20:32 +0530, Sanjeev Premi wrote:
> With current level, it shows up on the console
> despite using 'silent' in bootargs.
>
> Signed-off-by: Sanjeev Premi <premi@xxxxxx>
> ---
>
> 1) Couldn't find better text on commit message.
> Any suggestions?
>
> 2) Though pm34xx.x is changed, the change itself
> is no related to power management. Hence, did
> annotate "pm:"
Well, it's a change to PM core code, so PM prefix is fine. How about:
OMAP3: PM: boot message is not an error, use pr_info
Also, please Cc linux-arm-kernel, and I will queue this fix for 2.6.40.
Minor comment below..
> arch/arm/mach-omap2/pm34xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 343027f..7584ba8 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -901,7 +901,7 @@ static int __init omap3_pm_init(void)
>
> pm_errata_configure();
>
> - printk(KERN_ERR "Power Management for TI OMAP3.\n");
> + pr_info ("Power Management for TI OMAP3.\n");
Drop space before the opening '('.
> /* XXX prcm_setup_regs needs to be before enabling hw
> * supervised mode for powerdomains */
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
