On Thu, 2011-05-05 at 18:59 +0300, Tomi Valkeinen wrote: > Hi Paul, Benoit, > > I've started testing pm runtime with DSS, and I encountered a problem. > > I'm using latest -rc5 as a base, and it looks like > omap_hwmod:_wait_target_ready() does not succeed for dss_core hwmod. > This causes _enable() to fail, but omap_device_enable_hwmods() does not > check the return values so it looks like everything went well, until the > driver crashes as the DSS HW module was off. > > Ideas about _wait_target_ready()? And omap_device_enable_hwmods() would > need some fixing, I wasted quite a while debugging this =). Ah, the HW needs dss_dss_clk to be enabled before calling pm_runtime_get, otherwise _wait_target_ready() fails. Now that I think, I guess Sumit mentioned this at some point. Too bad, I was hoping I could enable the required opt clocks in runtime_resume callback. Shouldn't the hwmod code be able to enable/reset/etc the HW module independently? I wonder if this goes for all other DSS modules also... Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html