On Thu, May 5, 2011 at 5:29 AM, Kevin Hilman <khilman@xxxxxx> wrote: > "Govindraj.R" <govindraj.raja@xxxxxx> writes: > >> Add api to enable io_pad wakeup based on mux dynamic pad and > > s/api/API/ > s/io_pad/IO pad/ will update. > >> wake_up enable flag initialized during hwmod_mux. >> >> Use the wakeup flag and pad_remux flag and enable wakeup capability >> for the pad having these flags enabled. >> >> Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> > > This patch (except for the serial.c hange) isn't really dependent on the > rest of this series, and should be a separate patch to be merged by > Paul. > Yes. fine will post out hwmod API additions as separate patch. > Some other comments below... > >> --- >> arch/arm/mach-omap2/omap_hwmod.c | 34 +++++++++++++++++++++++++ >> arch/arm/mach-omap2/serial.c | 6 ++++ >> arch/arm/plat-omap/include/plat/omap_device.h | 1 + >> arch/arm/plat-omap/include/plat/omap_hwmod.h | 1 + >> arch/arm/plat-omap/omap_device.c | 26 +++++++++++++++++++ >> 5 files changed, 68 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c >> index e034294..4a12336 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod.c >> +++ b/arch/arm/mach-omap2/omap_hwmod.c >> @@ -2369,3 +2369,37 @@ int omap_hwmod_no_setup_reset(struct omap_hwmod *oh) >> >> return 0; >> } >> + >> +/** >> + * omap_hwmod_enable_ioring_wakeup - Set wakeup bit for iopad ring. >> + * @oh: struct omap_hwmod * >> + * @enable: based on 0 or 1 set or unset wakeup bit. > > more specifically, when true, set wakeup bit, when false, clear wakeup bit ok. > >> + * traverse through dynamic pads. If pad is enabled then >> + * set wakeup bit for the mux pin. Return error if pads are >> + * not enabled or not available. >> + */ > > The comment here should be clearer about when the bit actually gets > set. Specifically, this function doesn't actually write the value out, > but instead it configures the value which will be used during the hwmod > idle transition. > Yes correct. Will update the comments. > Kevin > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
