* Govindraj <govindraj.ti@xxxxxxxxx> [110504 03:03]:
> On Wed, May 4, 2011 at 3:25 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > * Govindraj.R <govindraj.raja@xxxxxx> [110429 05:39]:
> >> @@ -250,7 +251,7 @@ static void __init omap_2430sdp_init(void)
> >> Â Â Â omap2430_i2c_init();
> >>
> >> Â Â Â platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
> >> - Â Â omap_serial_init();
> >> + Â Â omap_serial_init(NULL);
> >> Â Â Â omap2_hsmmc_init(mmc);
> >> Â Â Â omap2_usbfs_init(&sdp2430_usb_config);
> > ...
> >
> >> Âstatic inline void board_serial_init(void)
> >> Â{
> >> - Â Â omap_serial_init();
> >> + Â Â omap_serial_init(NULL);
> >> Â}
> >
> > This change seems like "crazy churn" and probably not needed
> > if it's always null. Boards using platform_data can use
> > omap_serial_init_port instead, right?
>
> We can intiliaze only one uart port with omap_serial_init_port.
>
> omap_serial_init initializes all uart port.
>
> During any client device integration using dma mode
> (for example Bluetooth) we can pass the dma config
> params based on the board & client device.
But you're changing all omap_serial_init() calls to
omap_serial_init(NULL) so there are no users for that.
It should be a separate patch if it's needed.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
