* Mike Rapoport <mike@xxxxxxxxxxxxxx> [110504 09:35]: > On 05/04/11 07:10, Oleg Drokin wrote: > > Ok, so here's a simple patch to save everyone trouble, I guess. > > > > Though on the other hand I can imagine that perhaps including this generic common-board-devices.c > > might not be desirable for people that don't use anything from that file. > > Since the common-board-devices.c has TWL initialization I doubt there would a > board that does not use it at all... > > > Would it be a better idea to split it to a file-per-feature? > > Splitting the common-board-devices into a file-per-feature will diminish its > added value, IMO. > We can either continue to use #ifdef CONFIG_SOMETHING in both > common-board-devices.[ch] as your fix proposes or just drop #ifdefs and inlines > from the header. > Tony, what is your preference? We should consider the code size too.. Maybe see if you can make them weak instead of the ifdefs? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
