Hello! This patch breaks compile for me. On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote: > --- /dev/null > +++ b/arch/arm/mach-omap2/common-board-devices.c > @@ -0,0 +1,85 @@ > > +void __init omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce, > + struct ads7846_platform_data *board_pdata) > +{ > ... > +} > diff --git a/arch/arm/mach-omap2/common-board-devices.h b/arch/arm/mach-omap2/common-board-devices.h > new file mode 100644 > index 0000000..75f9248d > --- /dev/null > +++ b/arch/arm/mach-omap2/common-board-devices.h > @@ -0,0 +1,18 @@ > +#ifndef __OMAP_COMMON_BOARD_DEVICES__ > +#define __OMAP_COMMON_BOARD_DEVICES__ > + > +#if defined(CONFIG_TOUCHSCREEN_ADS7846) || \ > + defined(CONFIG_TOUCHSCREEN_ADS7846_MODULE) > +struct ads7846_platform_data; > + > +void omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce, > + struct ads7846_platform_data *board_pdata); > +#else arch/arm/mach-omap2/common-board-devices.c:80: error: redefinition of 'omap_ads7846_init' arch/arm/mach-omap2/common-board-devices.h:36: note: previous definition of 'omap_ads7846_init' was here Of course I don't have the CONFIG_TOUCHSCREEN_ADS7846 defined. Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html