"Varadarajan, Charulatha" <charu@xxxxxx> writes:
> On Sat, Apr 23, 2011 at 04:32, Kevin Hilman <khilman@xxxxxx> wrote:
>> Make _set_gpio_wakeup() generic by removing ifdefs. ÂCode for the
>> various SoCs/bank-methods was already the same, except for the
>> non-wakeup GPIO checking. ÂBut that flag is set on a per-SoC basis, so
>> can be used for all SoCs.
>>
>> While here, use pr_err() and remove GPIO bank calculation assumption
>> based on subtracting bank pointers.
>>
>> Signed-off-by: Kevin Hilman <khilman@xxxxxx>
[...]
>> -#endif
>> - Â Â Â default:
>> - Â Â Â Â Â Â Â printk(KERN_ERR "Can't enable GPIO wakeup for method %i\n",
>> - Â Â Â Â Â Â Â Â Â Â Âbank->method);
>> + Â Â Â if (bank->non_wakeup_gpios & gpio_bit) {
>> + Â Â Â Â Â Â Â pr_err("Unable to modify wakeup on non-wakeup GPIO%d\n", gpio);
>
> use dev_err instead.
Agreed, thanks.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
