Hi, > -----Original Message----- > From: ext Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx] > Sent: 30. huhtikuuta 2011 22:24 > To: Jokiniemi Kalle (Nokia-SD/Tampere) > Cc: tony@xxxxxxxxxxx; Ailus Sakari (Nokia-SD/Helsinki); linux- > omap@xxxxxxxxxxxxxxx; lrg@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/1] OMAP3: rx-51: Add full regulator definitions > > On Fri, Apr 29, 2011 at 03:47:44PM +0300, Kalle Jokiniemi wrote: > > > + .always_on = true, > > + .valid_modes_mask = REGULATOR_MODE_NORMAL > > + | REGULATOR_MODE_STANDBY, > > + .valid_ops_mask = REGULATOR_CHANGE_MODE > > + | REGULATOR_CHANGE_STATUS, > > _CHANGE_STATUS doesn't make much sense in conjunction with always_on. > Otherwise this looks OK to me. Ok, I'll remove those. Thanks. - Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html