Hello! On Apr 28, 2011, at 1:05 PM, Paul Walmsley wrote: >> Ok, this is a second attempt at B&N Nook Color board file submission. >> USB peripheral mode is fully operational as is serial console and >> MMC/SDCard. > It's good that you're sending these patches, but please also: > - Add a Signed-off-by: to each patch (see item 12 of > Documentation/SubmittingPatches) Ah, sure. Somehow I assumed this one is auto generated for the patch submitter. (never was a problem in the past at least). > - Cc Vikram, the original author of the board file, in the patch messages Ok, though I am not sure he is the original author of the nook color board file (since (C) 2008 well predates the Nook Color), the work I base this all off is from NookColor B&N source code drop and unfortunately people that worked on it did not identify themselves (or I don't see it) aside from just names in some debug comments. > - Cc the linux-arm-kernel@xxxxxxxxxxxxxxxxxxx mailing list Ok, I am expecting the patch will still get quite a bit of scrutiny so I'll wait for more feedback and next submission would be conforming. Thanks! Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html