On Tue, Apr 26, 2011 at 02:32:04PM +0530, Keshava Munegowda wrote: > > -----Original Message----- > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > Sent: Tuesday, April 26, 2011 2:29 PM > > To: Keshava Munegowda > > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; balbi@xxxxxx; > gadiyar@xxxxxx; p- > > basak2@xxxxxx; axel.lin@xxxxxxxxx; johnstul@xxxxxxxxxx; > mpfj-list@xxxxxxxxxx > > Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling > > > > Hi, > > > > On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote: > > > From: Axel Lin <axel.lin@xxxxxxxxx> > > > > > > In the case of missing platform_data we do not hold a spin_lock, > > > thus we should not call spin_unlock_irqrestore in the error path. > > > > > > Also simplify the error handling by separating the successful path > > > from error path. I think this change improves readability. > > > > > > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> > > > > Can someone give me a Tested-by so I can take these patches. > > > > -- > > Balbi > > Hi Balbi > > I have validated this patch and it works :) > > Tested-by: Keshava Munegowda <keshava_mgowda@xxxxxx> what about the others ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
