On Thu, Mar 31, 2011 at 06:30:32PM +0300, Ameya Palande wrote: > Hi Felipe, > > On 03/31/2011 05:26 PM, ext Felipe Balbi wrote: > >Hi, > > > >On Thu, Mar 31, 2011 at 04:38:12PM +0300, Ameya Palande wrote: > >>+static int rx51_lp5523_setup(void) > >>+{ > >>+ int err; > >>+ > >>+ err = gpio_request_one(RX51_LP5523_CHIP_EN_GPIO, GPIOF_DIR_OUT, > >>+ "lp5523_enable"); > >>+ if (err< 0) { > >>+ pr_err("Unable to get lp5523_enable GPIO\n"); > >>+ return err; > >>+ } > >>+ > >>+ return err; > > > >isn't enough to return gpio_request_one(RX51_LP5523_CHIP_EN_GPIO, > >GPIOF_DIR_OUT, "lp5523_enable"); ?? > > But then we won't know the failure reason for lp5523_probe() > I would prefer printing an error! see that both gpio_request() and gpio_direction_output() have debugging prints for error cases ;-) -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html