Paul Walmsley <paul@xxxxxxxxx> writes: > Hi Kevin > > you might want to consider renaming > > OMAP3_PRM_VC_VDD_MPU_ID > > etc. to something like: > > OMAP3_VC_VDD_MPU_ID > > and to define those in some vc.h header file. OK > Also, I'd suggest moving the struct omap_prm_vc_ops assignments out of the > prm*.c code into the vcXXXX_data.c files, ideally into some initcall, and > renaming the struct omap_prm_vc_ops to simply struct omap_vc_ops. OK > As long as the VC's low-level registers are in the PRM, those reads/writes > should happen through PRM code, IMHO. OK, what I will probably do then is at least create some omapX_prm_vc_read/write/rmw functions in prmXXXX.c. The prototypes for these will be identical for OMAP3 & 4, so the read/writes can be called from SoC independent code (via func ptrs) as needed. I'll try this approach on Monday. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
