Re: [PATCH] omap: hwmod: add syss reset done flags to omap2, omap3 hwmods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 25 Mar 2011, Cousson, Benoit wrote:

> On 3/25/2011 6:38 AM, Paul Walmsley wrote:
> > > > On Thu, 24 Feb 2011, Avinash.H.M wrote:
> > > > > Some of the omap2, omap3 peripherals support software reset. This
> > > > > can be done through the softreset bit in sysconfig register.
> > > > > The reset status can be checked through resetdone bit of
> > > > > sysstatus register. syss_has_reset_status is added to the hwmod
> > > > > database of peripherals which have resetdone bit in sysstatus
> > > > > register.
> > > > > 
> > > > > Cc: Rajendra Nayak<rnayak@xxxxxx>
> > > > > Cc: Paul Walmsley<paul@xxxxxxxxx>
> > > > > Cc: Benoit Cousson<b-cousson@xxxxxx>
> > > > > Cc: Kevin Hilman<khilman@xxxxxx>
> > > > > Reviewed-by: Govindraj.R<govindraj.raja@xxxxxx>
> > > > > Signed-off-by: Avinash.H.M<avinashhm@xxxxxx>
> > 
> > This patch is causing I2C softreset timeouts in the hwmod layer on OMAP2
> > and 3.  Could you please take a look at this and figure out what is going
> > on?
> 
> I think this is probably due to the nasty I2C softreset bug with discussed
> last year with Paul Brady.
> 
> AFAIR, the I2C cannot be reset by just writing to the SYSCONFIG softreset bit.
> You need to play with other registers too.

Thanks Benoît.

So then, Avinash, you might need to create a custom hwmod class 
reset function for the I2C block (viz., struct omap_hwmod_class.reset)

> Avinash,
> You should try to look at 3430 or 3630 errata. You will probably find the bug
> I'm referring to.


- Paul

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux