Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> writes: [...] >> + >> +/** >> + * voltdm_for_each - call function on each registered voltagedomain >> + * @fn: callback function * >> + * >> + * Call the supplied function @fn for each registered voltagedomain. >> + * The callback function @fn can return anything but 0 to bail out >> + * early from the iterator. ÂReturns the last return value of the >> + * callback function, which should be 0 for success or anything else >> + * to indicate failure; or -EINVAL if the function pointer is null. > > The function description does not match the prototype. > in what way? the description is wrong in how it describes the "bail out" but I don't see what you mean for the prototype. [...] >> >> +struct powerdomain; >> + >> +/* >> + * Maximum number of powerdomains that can be associated with a voltagedomain. >> + */ >> +#define VOLTDM_MAX_PWRDMS Â Â Â Â Â Â 10 > This is not used in the patch. Is it needed? > Nope. Will drop. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
