Vishwanath Sripathy <vishwanath.bs@xxxxxx> writes: >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman >> Sent: Friday, March 25, 2011 5:40 AM >> To: linux-omap@xxxxxxxxxxxxxxx >> Cc: Paul Walmsely; Benoit Cousson >> Subject: [PATCH] OMAP2+: VC: add SoC-specific op for PMIC register >> addresses >> >> Add a new SoC-specific operation for setting PMIC register addresses >> in the VC for the voltage configuration register and command >> configuration register. >> >> Some PMICs use a single register for voltage configuration and >> on/retention/off commands, others use separate registers. This patch >> adds a VC operation for setting these registers. The voltage >> configuration register is required, and the command register may >> optionally be zero, meaning it is not used. The command register >> address is only written to the VC if it is non-zero. > > What about PRM_VC_VAL_BYPASS register? If a PMIC is connected via only > sr-i2c, then PMIC can be configured only via this register. Shouldn't it > be abstracted as part of this patch or patch series? Yes. So far this series just splits out the setting of the slave address and the PMIC register addresses. Once we are happy with this approach (hence the RFC patches) I will continue splitting out the other functionality in a similar way. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html