"Premi, Sanjeev" <premi@xxxxxx> writes:
[...]
>
>> diff --git a/arch/arm/mach-omap2/voltage.h
>> b/arch/arm/mach-omap2/voltage.h
>> index e9f5408..44edc1e 100644
>> --- a/arch/arm/mach-omap2/voltage.h
>> +++ b/arch/arm/mach-omap2/voltage.h
>> @@ -133,6 +133,9 @@ struct omap_vdd_info {
>> struct dentry *debug_dir;
>> u32 curr_volt;
>> bool vp_enabled;
>> +
>> + s16 prm_mod;
>> + s16 prm_irqst_mod;
>
> [sp] Can we match the type with the functions these are eventually
> passed to?
Looking closer at this, the functions that these values are passed to
actually take s16 values, so I will leave them as s16.
For example, for OMAP2/3, see prm2xxx_3xxx.h:
extern u32 omap2_prm_read_mod_reg(s16 module, u16 idx);
extern void omap2_prm_write_mod_reg(u32 val, s16 module, u16 idx);
The reason this is important is that on 3430, these module offsets might
actually be negative (c.f. OMAP3430_IVA2_MOD in prcm-common.h)
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
