Hi Kevin,
a couple of comments below..
On Fri, 18 Mar 2011, Kevin Hilman wrote:
> Add voltage domain name to indicate which voltagedomain each
> powerdomain is in. A missing voltage domain name means that that
> powerdomain is not in one of the currently scalable voltage domains.
Before you add these, you might want to change the voltagedomain names for
OMAP3. I don't think it's correct to refer to the VDD1 voltagedomain as
"mpu" since it includes both the MPU and IVA. Probably best to use simply
"vdd1" and "vdd2" since that is the historical usage.
also...
>
> Signed-off-by: Kevin Hilman <khilman@xxxxxx>
> ---
> arch/arm/mach-omap2/powerdomains3xxx_data.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c b/arch/arm/mach-omap2/powerdomains3xxx_data.c
> index 9c9c113..bd01025 100644
> --- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
> +++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
> @@ -52,6 +52,7 @@ static struct powerdomain iva2_pwrdm = {
> [2] = PWRSTS_OFF_ON,
> [3] = PWRSTS_ON,
> },
> + .voltdm = { .name = "mpu" },
> };
>
> static struct powerdomain mpu_3xxx_pwrdm = {
> @@ -68,6 +69,7 @@ static struct powerdomain mpu_3xxx_pwrdm = {
> .pwrsts_mem_on = {
> [0] = PWRSTS_OFF_ON,
> },
> + .voltdm = { .name = "mpu" },
> };
>
> /*
> @@ -98,6 +100,7 @@ static struct powerdomain core_3xxx_pre_es3_1_pwrdm = {
> [0] = PWRSTS_OFF_RET_ON, /* MEM1ONSTATE */
> [1] = PWRSTS_OFF_RET_ON, /* MEM2ONSTATE */
> },
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain core_3xxx_es3_1_pwrdm = {
> @@ -121,6 +124,7 @@ static struct powerdomain core_3xxx_es3_1_pwrdm = {
> [0] = PWRSTS_OFF_RET_ON, /* MEM1ONSTATE */
> [1] = PWRSTS_OFF_RET_ON, /* MEM2ONSTATE */
> },
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain dss_pwrdm = {
> @@ -157,6 +161,7 @@ static struct powerdomain sgx_pwrdm = {
> .pwrsts_mem_on = {
> [0] = PWRSTS_ON, /* MEMONSTATE */
> },
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain cam_pwrdm = {
> @@ -172,6 +177,7 @@ static struct powerdomain cam_pwrdm = {
> .pwrsts_mem_on = {
> [0] = PWRSTS_ON, /* MEMONSTATE */
> },
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain per_pwrdm = {
> @@ -187,12 +193,14 @@ static struct powerdomain per_pwrdm = {
> .pwrsts_mem_on = {
> [0] = PWRSTS_ON, /* MEMONSTATE */
> },
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain emu_pwrdm = {
> .name = "emu_pwrdm",
> .prcm_offs = OMAP3430_EMU_MOD,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain neon_pwrdm = {
> @@ -201,6 +209,7 @@ static struct powerdomain neon_pwrdm = {
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> .pwrsts = PWRSTS_OFF_RET_ON,
> .pwrsts_logic_ret = PWRSTS_RET,
> + .voltdm = { .name = "core" },
This is in VDD1.
> };
>
> static struct powerdomain usbhost_pwrdm = {
> @@ -223,6 +232,7 @@ static struct powerdomain usbhost_pwrdm = {
> .pwrsts_mem_on = {
> [0] = PWRSTS_ON, /* MEMONSTATE */
> },
> + .voltdm = { .name = "core" },
> };
>
> static struct powerdomain dpll1_pwrdm = {
These DPLL powerdomains should have voltagedomains also. DPLL1 is in
VDD1, I believe. I think the rest are in VDD2.
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
