> -----Original Message-----
> From: Hilman, Kevin
> Sent: Friday, March 18, 2011 1:42 AM
> To: Premi, Sanjeev
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] omap3: voltage: fix variable type and name
>
> Sanjeev Premi <premi@xxxxxx> writes:
>
> > In all usages, variables prm_mod_offs and prm_irqst_ocp_mod_offs
> > are expected to be "u16" but have been declared as "s16".
>
> What kind of problem is that causing?
[sp] No, it wasn't causing any problems 0 because offset value wouldn't
reach the signed / unsigned limits; but didn't seem right while
reading the code.
~sanjeev
>
> Kevin
>
> > In addition, renamed prm_irqst_ocp_mod_offs to ocp_sysreg_prm_offs
> > for better association with the TRM. Original name perhaps came
> > from the current usage of this offset to reach PRM_IRQSTATUS_MPU
> > offset.
[snip]...[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
