Aaro Koskinen <aaro.koskinen@xxxxxxxxx> writes: > Hi, > > On Thu, 17 Mar 2011, Kevin Hilman wrote: >> >> Thanks, queuing for 2.6.40. >> > [...] >> >>> - iounmap(sr_info->base); >>> - mem = platform_get_resource(sr_info->pdev, IORESOURCE_MEM, 0); >>> - release_mem_region(mem->start, resource_size(mem)); >>> - list_del(&sr_info->node); >>> - dev_err(&sr_info->pdev->dev, "%s: ERROR in registering" >>> - "interrupt handler. Smartreflex will" >>> - "not function as desired\n", __func__); >>> - kfree(name); >>> - kfree(sr_info); >>> - return ret; >>> + iounmap(sr_info->base); >>> + mem = platform_get_resource(sr_info->pdev, IORESOURCE_MEM, 0); >>> + release_mem_region(mem->start, resource_size(mem)); >>> + list_del(&sr_info->node); >>> + dev_err(&sr_info->pdev->dev, "%s: ERROR in registering" >>> + "interrupt handler. Smartreflex will" >>> + "not function as desired\n", __func__); >>> + kfree(name); >>> + kfree(sr_info); >>> + return ret; > > Just FYI, this code is partly broken and probably need to be fixed in .39. OK > Some of those resources are also freed by omap_sr_probe() when > sr_late_init() fails and that cannot be correct. Got a patch around to fix that? Sounds like something we should get into the .39-rc cycle. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
