Re: 2420 sDMA address mapping typo

"Cousson, Benoit" <b-cousson@xxxxxx> · Tue, 15 Mar 2011 21:32:23 +0100

Salut Michael,

On 3/15/2011 5:44 PM, Fillinger, Michael wrote:
Hi,

There is a small issue introduced in 2.6.38 on the address space of sDMA for OMAP2420, which seems to be a mix of OMAP2&  newer OMAP addresses :

arch/arm/mach-omap2/omap_hwmod_2420_data.c

static struct omap_hwmod_addr_space omap2420_dma_system_addrs[] = {
         {
                  .pa_start   = 0x48056000,
                  .pa_end     = 0x4a0560ff,
                  .flags      = ADDR_TYPE_RT
         },
};

pa_end should be 0x480560ff unless I'm mistaken.

Good catch, but the size is almost 4k to store all the channels.

The quick and dirty patch is:
-                   .pa_end     = 0x4a0560ff,
+                   .pa_end     = 0x48056fff,

Thanks,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html