Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: >> -----Original Message----- >> From: Kevin Hilman [mailto:khilman@xxxxxx] >> Sent: Friday, March 11, 2011 11:20 PM >> To: Santosh Shilimkar >> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; Rajendra Nayak >> Subject: Re: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and >> CPUilde support. >> >> Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: >> > [...] > >> >> I prefer to drop it completely for OMAP4. >> >> >> > OK. Lets do that. >> > >> > Just to not miss your point here, what I understood here >> > is default suspend state on OMAP$B will be off mode. >> > >> > We still keep "enable_off_mode" flag for testing so that we >> > can disable off mode to debug regressions. >> > >> > Is that right? >> >> No, I want to drop "enable_off_mode" all together for OMAP4. >> >> If you want to change any powerdomain's default next_state, you can >> use >> the <debugfs>/pm_debug/*_pwrdm/suspend controls. >> > Thanks for clarification. The change is quite trivial. Will > update the branch with this change. > After testing it, will intimate you One other thing to check... I've now included Russell's devel branch into my pm-core branch. Can you rebase your series there? I did a test rebase of v3 and it rebased fine (after dropping the patches that are already in devel.) After doing that, I get a compile error: arch/arm/mach-omap2/built-in.o: In function `mmu_on_label': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep44xx.S:394: undefined reference to `PHYS_OFFSET' make[1]: *** [.tmp_vmlinux1] Error 1 make: *** [sub-make] Error 2 It looks like there might be some other changes in Russell's queue that you need to take into consideration. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
