Kevin, > -----Original Message----- > From: linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:linux- > arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman > Sent: Friday, March 11, 2011 9:22 PM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; Rajendra Nayak > Subject: Re: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and > CPUilde support. > [....] > > > > So just to summaries, on OMAP$ 'enable_off_mode' flag is > > used __only__ in Suspend. CPUx power domain always hit OFF > > mode no matter what is state of this flag because CSWR isn't > > supported on these PD's. > > If it's useful only in suspend, then it's redundant with the > <debugfs>/pm_debug/*_pwrdm/suspend controls which allow per-pwrdm > control over next states. > > > We could remove this flag as well but thought that this might be > > useful especially when we add CORE RET, DEVICE OFF support. > > I'd rather see working off-mode be a requirement for getting OMAP4 > drivers supported. > > Also, we can still test suspend/resume with off-mode disabled by > using the above debugfs controls. > > > May be we keep this till the constraint frameworks comes in and > > then drop it once for all. I am ok with whatever direction you > > decide here. > > I prefer to drop it completely for OMAP4. > OK. Lets do that. Just to not miss your point here, what I understood here is default suspend state on OMAP$B will be off mode. We still keep "enable_off_mode" flag for testing so that we can disable off mode to debug regressions. Is that right? If yes then only below update is needed. diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c index 2e18c1d..1a8cbdd 100644 --- a/arch/arm/mach-omap2/pm44xx.c +++ b/arch/arm/mach-omap2/pm44xx.c @@ -167,7 +167,7 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused) return -ENOMEM; pwrst->pwrdm = pwrdm; - pwrst->next_state = PWRDM_POWER_RET; + pwrst->next_state = PWRDM_POWER_OFF; list_add(&pwrst->node, &pwrst_list); return omap_set_pwrdm_state(pwrst->pwrdm, pwrst->next_state); @@ -253,6 +253,8 @@ static int __init omap4_pm_init(void) pr_err("Failed to initialise OMAP4 MPUSS\n"); goto err2; } + + enable_off_mode = 1; #endif #ifdef CONFIG_SUSPEND -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
