RE: [PATCH 2/2] OMAP3: wdtimer: Fix CORE idle transition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> -----Original Message-----
> From: ext Cousson, Benoit [mailto:b-cousson@xxxxxx]
> Sent: 10. maaliskuuta 2011 13:23
> To: Jokiniemi Kalle (Nokia-MS/Tampere)
> Cc: paul@xxxxxxxxx; Hilman, Kevin; tony@xxxxxxxxxxx; linux-
> omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] OMAP3: wdtimer: Fix CORE idle transition
> 
> On 3/10/2011 11:54 AM, Kalle Jokiniemi wrote:
> > From: Paul Walmsley<paul@xxxxxxxxx>
> >
> > The HW superwised smart idle for wdtimer in OMAP3 prevents CORE
> power
> > domain idle transitions. Disable it by swithing to SW supervised
> > transitions.
> 
> We should probably highlight that this looks like a HW bug.
> Smartidle and clockactivity are supposed to be supported by this module on
> OMAP3.
> 
> Some further investigation with TI HW folks are needed to understand that.

I added a comment also to the code in the last version of the 2/2 patch, in case you find something and want to do some improvements.

- Kalle

> 
> Regards,
> Benoit
> 
> >
> > Signed-off-by: Kalle Jokiniemi<kalle.jokiniemi@xxxxxxxxx>
> > Signed-off-by: Paul Walmsley<paul@xxxxxxxxx>
> > ---
> >   arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    1 +
> >   1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > index 196a834..a99a4f3 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > @@ -1293,6 +1293,7 @@ static struct omap_hwmod
> omap3xxx_wd_timer2_hwmod = {
> >   	.slaves		= omap3xxx_wd_timer2_slaves,
> >   	.slaves_cnt	= ARRAY_SIZE(omap3xxx_wd_timer2_slaves),
> >   	.omap_chip	= OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> > +	.flags		= HWMOD_SWSUP_SIDLE,
> >   };
> >
> >   /* UART common */

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux