On Fri, 2011-03-04 at 09:25 -0600, Steve Sakoman wrote: > On Fri, Mar 4, 2011 at 12:00 AM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > > Why check for CONFIG_PANEL_LGPHILIPS_LB035Q02, but not for the lcd43? > > > > And is that even necessary? Of course it would make the kernel very > > slightly smaller if you leave some code out, but otherwise does that > > help? If you have the device definitions there, but the user doesn't > > load the driver, they wouldn't do anything, would they? > > > > For me the ifdefs just make the code harder to read, but I'm not sure if > > there's some standard custom to have these. <snip> > The spidev driver turns out to be useful for a lot of embedded > applications, so I would prefer to leave the check in place if you > agree that this could be useful. Yes, sounds like a valid reason to me. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
