On Thu, Mar 3, 2011 at 11:55 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > Hi, > > On Thu, 2011-03-03 at 17:46 -0600, Steve Sakoman wrote: >> This patch adds support for the Gumstix Palo35 expansion board >> which utilizes the 320 x 240 pixel LG.Philips LB035Q02 LCD Panel >> >> Signed-off-by: Steve Sakoman <steve@xxxxxxxxxxx> > > This looks about as good as the other panel drivers. Which means it > works for now but it does has faults =). > > One thing to fix: > > - There should be locking here. Check panel-taal.c. Mutexes around the > xxx_panel_enable() etc calls should do the thing. OK, I will resubmit with this fixed. > And another thing to think about, but there's probably not a simple fix > for this right now: > > This wouldn't work with two panel devices. If you think the case where > you have to panels, meaning two spi devices and two dss devices. You > first register the spi driver, which would call probe for both of the > spi devices. The first spi probe call would registers the dss driver, > which would call probe for both of the dss devices. At this point only > the first spi device would have been probed... > > This is a bit tricky, and I'm not sure if there's any ready-made > solution for this. But what we need is a way to link a spesific spi > device to a specific dss device in the board file. > > Then this panel module would register both dss driver and spi driver in > the module_init(), and after both dss and spi probe has been called for > the particular dss+spi device pair, the actual display driver would > start. > > So this needs some work, and also some careful checks in, for example, > panel_enable, because nothing says that the spi device is ready when > panel_enable is called. Well, on Overo it would not be possible to add more than one Palo35, but I see your point in theory. Do you want me to try to address this in this initial submission, or is it something we can revisit in a subsequent "fix-it" patch for all panels with SPI init? Steve -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
