On Thu, Mar 03, 2011 at 03:21:29PM +0100, Michael Büsch wrote: > On Thu, 2011-03-03 at 11:43 +0200, Felipe Balbi wrote: > > On Wed, Mar 02, 2011 at 05:11:53PM +0100, Michael Buesch wrote: > > > An unsigned int pointer must not be casted to an unsigned > > > long pointer before use. Convert the bitfield to unsigned long > > > to fix this. > > > Also use clear_bit() in the release path. > > > > > > Signed-off-by: Michael Buesch <mb@xxxxxxxxx> > > > > This looks ok, I'm just wondering if the change on test_and_set_bit() > > from bit 1 to bit 0 should be on this patch. I guess not. > > Uh, well. If that's worth doing a separate patch, I'll do it. > It doesn't actually really matter if we use bit 0, 1 or ... for this. > I just thought it was weird to use the second bit. yeah, I didn't read the whole code before making the comment, if you're sure no-one is using bit 0, then go for it. Having it separate, would help on bisecting should things go wrong. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
