Re: [PATCH] cbus-retu-wdt: Fix bitfield access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 02, 2011 at 05:11:53PM +0100, Michael Buesch wrote:
> An unsigned int pointer must not be casted to an unsigned
> long pointer before use. Convert the bitfield to unsigned long
> to fix this.
> Also use clear_bit() in the release path.
> 
> Signed-off-by: Michael Buesch <mb@xxxxxxxxx>

This looks ok, I'm just wondering if the change on test_and_set_bit()
from bit 1 to bit 0 should be on this patch. I guess not.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux