Hi Tomi, I have checked for static functions :) . Ok i will revisit the global variables to either move it to hdmi struct or make it const. Thanks and regards, Mythri. On Tue, Mar 1, 2011 at 11:07 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On Tue, 2011-03-01 at 08:16 -0600, K, Mythri P wrote: >> Adding the hdmi interface driver(hdmi.c) to the dss driver. >> It configures the audio and video portion of HDMI in the >> display header file to be accessed by the panels. > > Check once more if the private functions and variables are marked as > static. > > The edid variables should be in the hdmi struct. The constant data > arrays should be const. > > hdmi_power_on() leaves clocks on in case of error. > > Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html