On Tue, Mar 1, 2011 at 10:41 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On Tue, 2011-03-01 at 08:16 -0600, K, Mythri P wrote: >> The panel driver(hdmi_omap4_panel.c) in dss file acts as a controller >> to manage the enable and disable requests and synchronize audio and video. >> Also the header file to export the hdmi registers is added in the >> plat-omap , so that it can be accessed by audio driver. > > Could you review the description. The panel driver is not in "dss file" > and there's no header in this patch. > > The locking is broken in this patch. You cannot return from the function > while holding the lock. I shall fix the lock and describe appropriately. > > Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
